Denis, Below are a few comments ...
Paul Denis Migounov wrote: > > Please help review the changes to integrate cvs-1.11.22 (CR 6776223) > The webrev is at: http://cr.opensolaris.org/~dm223115/cvs.webrev/ === Start of Comments ==== 1. usr/src/cmd/cvs/Makefile.sfw Line ... 37 @find . -name core -exec rm -f {} \; do you really need this - if so why? if not delete it lines ... 53 find $(VER) -type d -exec /usr/bin/chmod 755 "{}" \; 54 find $(VER) -type f -exec /usr/bin/chmod ugo+r "{}" \; again do you really need these? If not delete them. 2. usr/src/cmd/cvs/install-cvs Roland Mainz wrote: > use /usr/bin/ksh93 or /usr/bin/bash for install-sfw* > and add a $ set -o errexit # at the beginning and > replace ". ${SRC}/tools/install.subr" with > "source ${SRC}/tools/install.subr" (the idea is to > catch failures in the script and abort it at that point, > right now the script will just continue) 3. old tarball the deleting of the old tarball version file should probably show up in the webrev. === End of Comments ====== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
