Paul,
Thanks for the explanation. I'll go ahead and remove these lines.
- Denis
Paul Cunningham wrote:
> Denis,
>
> Denis Migounov wrote:
>>
>> My comments are below.
>>
>> Paul Cunningham wrote:
>>> 1. usr/src/cmd/cvs/Makefile.sfw
>>> Line ...
>>> 37 @find . -name core -exec rm -f {} \;
>>> do you really need this - if so why? if not delete it
>>>
>>> lines ...
>>> 53 find $(VER) -type d -exec /usr/bin/chmod 755 "{}" \;
>>> 54 find $(VER) -type f -exec /usr/bin/chmod ugo+r "{}" \;
>>> again do you really need these? If not delete them.
>>>
>> These lines were in the Makefile used to build version 1.12.13 and I
>> just left them untouched.
>> Now, I talked to Maxim Kartashev (who ported 1.12.13) about why they
>> were put there originally,
>> and his answer was that these lines were needed to make sure that all
>> files had correct permissions,
>> since we (people who port the software) don't have control over the
>> the build process and never know
>> what might change in the scripts used to build the consolidation.
>
> I believe that those lines go back to the days of the CompanionCD and
> and are therefore historic (even before when I worked on the ccd and
> sfw stuff n years ago), they then got propagated from one pkg to the
> next next new pkg in the consolidation.
>
> They protentionally increase the sfw ws build time - so unless you
> know they are really required for your pkg I suggest you remove them.
> No recent new integrations into the sfw gate will have them.
>
> Paul
