On Feb 12, 2009, at 1:48 AM, Paul Cunningham wrote: > Bruce, > > This mainly looks good to me now. Just a couple of things ... > > In SUNWpowermanr/prototype_com ... > > 1. Line ... > 51 f none etc/init.d/powerman 0744 root sys > does this really need the write permission bit set? > I'm just following the way permissions are currently set in /etc/ init.d. Pretty much all exe's and scripts are 0744. If you don't set it writable won't there be a problem during upgrades when the patch tries to over write the old version?
ls -l total 210 -rwxr--r-- 2 root sys 1065 Jan 23 18:38 PRESERVE* -rw-r--r-- 1 root sys 3293 Jan 23 18:17 README -rwxr--r-- 1 root sys 1276 Jan 23 18:06 acct* -rwxr--r-- 6 root sys 2455 Jan 26 01:13 apache* -rwxr--r-- 5 root sys 824 Aug 16 2006 appserv* -rwxr-xr-x 2 root other 1558 Oct 20 02:56 autoinstall* -rwxr--r-- 6 root sys 1280 Jan 23 18:17 boot.server* -rwxr--r-- 2 root sys 2065 Jan 23 18:17 cachefs.daemon* -rwxr--r-- 2 root sys 1540 Jan 23 18:17 deallocate* -rwxr--r-- 1 root sys 1355 Jan 23 18:17 devlinks* -rwxr--r-- 1 root sys 1531 Jan 23 18:17 dhcp* -rwxr--r-- 2 root sys 1010 Jan 23 18:40 dodatadm.udaplt* -rwxr--r-- 1 root sys 1118 Jan 23 18:17 drvconfig* -rwxr--r-- 1 root sys 3003 Aug 26 13:46 dtlogin* -rwxr--r-- 1 root bin 2902 Jan 23 18:06 ii* -rwxr--r-- 1 root bin 1417 Jan 23 18:06 ii.cluster* > 2. Would the user want any of these /etc/* files to be preserved > when a new version of the pkg is installed? If so you need to > ensure that happens I don't know of any reason to preserve them they are written in a special powerman script language that the maintainers write for the community. So unless there is no other objections I'm going to consider this code reviewed. Bruce > > > paul > > > Bruce Rothermal wrote: >> Ok, I think I've got everything now. Could I please get another look. >> http://cr.opensolaris.org/~bruce_r/powerman-2.3/ > > -- > ---------------------------------------------------------------------- > Paul Cunningham > Software Engineer > Tadpole Business Unit >
