Heli, Here are my comments, some of them may duplicate comments from other people, see below ...
Paul Heli wrote: > > Please review the codes for httping porting. > Webrev: http://cr.opensolaris.org/~heli/httping/ > > > Httping is like 'ping' but for http-requests. Give it an url, and it'll > show you how long it takes to connect, send a request and retrieve the > reply. === Start of Comments ==== 1. usr/src/cmd/httping/METADATA Change this so it conforms to that in ... http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines 2. CDDL HEADERs in all new files Change, as appropriate, so that they conform to those in .. http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/prototypes/ (See http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines) 3. usr/src/cmd/httping/Makefile.sfw Change as .. Roland Mainz wrote: > use "env - ..." and not "env ..." in the Makefiles > to make sure "configure"&&"make" only see the env > variables they should really get (and not pick-up any > random env variable) Extract the ... 28 VERSION=1.2.9 29 PKGNAME=httping-$(VERSION) from the METADATA. See recent integrations for examples. 4. usr/src/cmd/httping/install-sfw Pass the VERSION= info in from the Makefile.sfw Roland Mainz wrote: > add a $ set -o errexit # at the beginning and replace > ". ${SRC}/tools/install.subr" with > "source ${SRC}/tools/install.subr" (the idea is to catch > failures in the script and abort it at that point, > right now the script will just continue) 5. usr/src/pkgdefs/SUNWhttping/copyright Does this need the Sun disclaimer at the top ? See .. http://src.opensolaris.org/source/xref/sfw/usr/src/pkgdefs/SUNWmeld/copyright 6. usr/src/pkgdefs/SUNWhttping/depend Move the Copyright lines to after the CDDL HEADER END header 7. usr/src/pkgdefs/SUNWhttping/pkginfo.tmpl Add version to end of DESC= line, eg. DESC="............. (1.2.9)" === End of Comments ====== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
