Hi Paul, Please see comments inline.
Paul Cunningham wrote: >>> Why is this ... >>> 36 JAVA_ROOT=/usr/jdk/j2sdk1.4.2_06 >>> different to the JAVA_ROOT in Makefile.master ? >> >> Since Imperius builds only with JDK.1.4.2, I have had to explicitly >> set the path > > It may be worth adding a comment to say that > Now I have added the -source option to compile with what is available by default in JAVA_ROOT. > >>> 6. usr/src/lib/imperius/antlr-2.7.7.jar >>> Where is this used ? >>> >> antlr-2.7.7.jar is used to build the imperius-splcore grammar files. >> This is required only at build time. > > How does that actually get included in the build, its no obvious to me > - may be add comment to Makefile.sfw to say how. But I maybe being > thick :-[ here. > Since it is a build time dependency it was thought to put the antlr.jar in the imperius dir for now and pick it up locally for the build. Once the antlr (LSARC/2009/075) gets integrated to sfw then remove this dependency and point to what is available in common across the system. > usr/src/pkgdefs/SUNWImperius/pkginfo.tmpl > Put version (what ever that might be) on the DESC= line, eg. ... > DESC=".............. (my-version)" Done Updated webrev: http://cr.opensolaris.org/~bkumarm/imperius/ Thanks Bharath -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.opensolaris.org/pipermail/sfwnv-discuss/attachments/20090220/b6e9e8c9/attachment.html>
