James, A few more comments below ...
Paul jin wan - Sun Microsystems - Beijing China wrote: > > Thanks very much of your review, and please see my answers to both of > your comments in lines. > > I sync the webrev at the same location: > http://cr.opensolaris.org/~bjwancn/dbunit/ > > On 02/20/09 17:20, Paul Cunningham wrote: >> >> === Start of Comments ==== >> >> 1. usr/src/lib/dbunit/METADATA >> This doesn't need the CDDL HEADER stuff >> >> Add missing fields, see ... >> http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines >> > Fixed The SRC: field is missing >> 6. usr/src/lib/dbunit/sunman/dbunit.3.sunman >> Is "Interface Stability External" correct? >> > Changed "External" to "Uncommitted" >> Add CDDL HEADER stuff >> > It seems no need to add CDDL HEADER in sunman file according to > "http://tas.sfbay/net/sfwnv.sfbay/gates/sfwnv/gate/usr/src/cmd/expect/sunman-stability"; > I can't see that link external to the SWAN; but sunman-stability file modifies existing man pages, yours is a new man Sun page so I think it probably needs it. >> 7. usr/src/pkgdefs/SUNWdbunit/copyright >> Add sun disclaimer and package src copyright stuff at top see .. >> "http://src.opensolaris.org/source/xref/sfw/usr/src/pkgdefs/SUNWmeld/copyright"; >> > > Fixed you might need to add the pkg owner copyright lines to >> 8. Pkg dependencies >> You are using the default 'depend', but have you checked >> your pkg has no other dependencies with the dependency >> checker script? > > Add a depend file You can delete the following in your SUNWdbunit/Makefile now ... 31 DATAFILES= depend as you have your own depend file. >> 10. usr/src/pkgdefs/SUNWdbunit/prototype_com >> Do you need to deliver the src stuff as part of this pkg, >> eg. in ... >> usr/share/doc/dbunit/src/* >> Just checking? >> > usr/share/doc/dbunit/src/* is the sample test code for dbunit, not the > src of dbunit itself. Are the ARC happy that you are delivering test src as part of the main package rather than in a pkg of its own? -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
