Jeffrey, Looks fine with the following comments:
usr/src/cmd/epydoc/METADATA - Tidy up the indentation, get everything to align usr/src/cmd/epydoc/install-sfw - What's different about epydoc and epydocgui that requires one to be installed as 'N' and the other as 'S'? usr/src/pkgdefs/SUNWepydoc/depend - Tidy up the indentation, get everything to align Amanda Jeffrey Huang wrote: > Hi, Amanda, > > I resynced my work space and re-generated the webrev together with fix > of Paul's review. > Please help to review when you have time. > > Thanks > Jeffrey > > Amanda waite : > >> At the moment you're removing stuff from usr/src/Targetdirs, >> usr/src/cmd/Makefile and usr/src/pkgdefs/Makefile. You need to resync >> with the parent, resolve any conflicts and then re-generate the webrev. >> >> Thanks >> >> Amanda >> >> >> Jeffrey Huang wrote: >> >> >>> Hi, >>> >>> Resend for the correct webrev link: >>> >>> http://cr.opensolaris.org/~jeffreyh/epydoc >>> <http://cr.opensolaris.org/%7Ejeffreyh/epydoc/> >>> >>> Jeffrey Huang ??: >>> >>> >>>> Hi, All >>>> >>>> I am porting 'epydoc', an automatic api documentation generation for >>>> python to OpenSolaris, >>>> epydoc is written in Python. >>>> >>>> Can you please have a review on my code. The webrev is at: >>>> >>>> http://cr.opensolaris.org/~jeffreyh/epydoc >>>> >>>> -- >>>> Great Thanks & Best Regards >>>> >>>> --- >>>> Jeffrey Huang SWAN: x51683, Ext: 0086-10-62673683 >>>> Solaris QE Group Email: jeffrey.huang at sun.com >>>> China Engineering & Research Institute, Sun Microsystems >>>> 7/F Chuang Xin Plaza, Tsinghua Science Park, Beijing China >>>> >>>> >>>> >>> -- >>> Great Thanks & Best Regards >>> >>> --- >>> Jeffrey Huang SWAN: x51683, Ext: 0086-10-62673683 >>> Solaris QE Group Email: jeffrey.huang at sun.com >>> China Engineering & Research Institute, Sun Microsystems >>> 7/F Chuang Xin Plaza, Tsinghua Science Park, Beijing China >>> >>> ------------------------------------------------------------------------ >>> >>> _______________________________________________ >>> sfwnv-discuss mailing list >>> sfwnv-discuss at opensolaris.org >>> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss >>> >>> >>> >> >> > > >
