Hi Jerry,
Below are my comments.
1. METADATA file is missing.
Please include the file and follow the guidelines outlined at
http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines
2. Please change the copyright year to 2009 through out.
3. Makefile.sfw
a) You can avoid hard-coding program name and version and instead
extract this info from METADATA, something like:
VER = $(COMPONENT_NAME:sh)-$(COMPONENT_VERSION:sh)
b) Use env - instead of env through out.
c) It is advisable to use $(SHELL) instead of $(SH).
d) You may want to call configure as "$(SHELL) ./configure"
e) You could use
CONFIGURE_OPTIONS += --localstatedir=/var --sysconfdir=/etc
and then call configure as
$(SHELL) ./configure $(CONFIGURE_OPTIONS)
f) If you intend to use /usr/sfw/bin/gtar then you could use it with
"-z" option to unzip the tarball instead of doing the same using 2
commands (/usr/bin/gzip -dc and /usr/sfw/bin/gtar )
4. install-sfw
a) It is recommended to use /usr/bin/ksh93 instead of /bin/sh. This
allows you to add:
# stop at first error
set -o errexit
And to call "source" instead of "." in this line:
source ${SRC}/tools/install.subr
b) You can pass VERS as an environment variable from the Makefile and
use it here.
c) You can use SBINDIR in the below:
_install L proftpd ${ROOT}/usr/sbin/in.proftpd
d) You could have a for loop to install the header files.
e) Do you require the write permission on the header files and man pages?
5. SUNWproftpdr/Makefile
a) You could use the default depend file here by adding
"DATAFILES=depend" in the Makefile if there are no project specific
dependencies. Please check.
6. SUNWproftpdr/pkginfo.tmpl
a) You may want to change the DESC field as
proftpd - Highly configurable FTP daemon server (1.3.1) (Root)
7. SUNWproftpdr/prototype_com
a) Are these two entries required?
48 d none var 755 root sys
49 d none var/proftpd 755 root root
8. SUNWproftpdu/depend
a) Move the copyright line after the CDDL header end.
b) Shouldn't SUNWproftpdu depend on SUNWproftpdr? If so, the same
needs to be mentioned in the depend file.
9. SUNWproftpdu/pkginfo.tmpl
a) You may want to change the DESC field as
proftpd - Highly configurable FTP daemon server (1.3.1) (Usr)
10. SUNWproftpdu/prototype_com
a) Is the below entry required?
d none usr/libexec 755 root root
11. You seem to be removing few entries from cmd/Makefile, Targetdirs
and pkgdefs/Makefile files. Please check.
Regards
Muktha
> Hi all,
>
> I will integrated proftpd 1.3.1 into OpenSolaris. The webrev has been
> posted to:
>
> http://cr.opensolaris.org/~bgun/proftpd/
>
> Please help me review it and send me your comments.
>
> Thanks,
> Jerry
> _______________________________________________
> sfwnv-discuss mailing list
> sfwnv-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss
>
