Petr, Just a few very minor comments ...
Paul Petr Sumbera wrote: > > John and me, we have created workspace for GNU Screen integration > (PSARC/2008/413). Can somebody please look at it? > > http://cr.opensolaris.org/~xsumbe00/6721648-screen/ === Start of Comments ==== 1. usr/src/pkgdefs/SUNWscreen/prototype_sparc Copyright year is wrong 2. usr/src/pkgdefs/SUNWscreen/prototype_com Do all the files need the write permission bit set? 3. usr/src/pkgdefs/SUNWscreen/Makefile You could remove the null DATAFILES= line 4. SUNWscreenrc This a 'root' package - they are normally just named SUNWscreenr (without the 'c') I think 5. usr/src/pkgdefs/SUNWscreenrc/pkginfo.tmpl The 'Configuration File' text on the NAME= and DESC= lines; for a 'root' pkg I think it's normal to just put "(root)" at the end of the text line 6. usr/src/pkgdefs/SUNWscreenrc/prototype_i386 & usr/src/pkgdefs/SUNWscreenrc/prototype_sparc Package name at end in comment line is wrong. 7. Everything else looks good to me === End of Comments ====== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Computer Products
