Hi Petr,
In the patch misc.c.patch instead of removing the entire OS check
line you can add (__sun) keyword. Attached is the patch for your reference.
thanks,
Pradhap.D
Paul Cunningham wrote:
> Petr,
>
> Just a few very minor comments ...
>
> Paul
>
> Petr Sumbera wrote:
>
>> John and me, we have created workspace for GNU Screen integration
>> (PSARC/2008/413). Can somebody please look at it?
>>
>> http://cr.opensolaris.org/~xsumbe00/6721648-screen/
>>
>
> === Start of Comments ====
>
> 1. usr/src/pkgdefs/SUNWscreen/prototype_sparc
> Copyright year is wrong
>
> 2. usr/src/pkgdefs/SUNWscreen/prototype_com
> Do all the files need the write permission bit set?
>
> 3. usr/src/pkgdefs/SUNWscreen/Makefile
> You could remove the null DATAFILES= line
>
> 4. SUNWscreenrc
> This a 'root' package - they are normally just
> named SUNWscreenr (without the 'c') I think
>
> 5. usr/src/pkgdefs/SUNWscreenrc/pkginfo.tmpl
> The 'Configuration File' text on the NAME= and DESC=
> lines; for a 'root' pkg I think it's normal to just
> put "(root)" at the end of the text line
>
> 6. usr/src/pkgdefs/SUNWscreenrc/prototype_i386
> & usr/src/pkgdefs/SUNWscreenrc/prototype_sparc
> Package name at end in comment line is wrong.
>
> 7. Everything else looks good to me
>
> === End of Comments ======
>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: screen-patch.txt
URL:
<http://mail.opensolaris.org/pipermail/sfwnv-discuss/attachments/20080908/27501c33/attachment.txt>
