Chris,
Chris Zhu wrote:
>
> We made some change to the Makefile and pkginfo according to the
> comments from Paul and Roland, which include
> 1) remove the version info from the NAME of package, depend file is
> also affected
> 2) change the VERSION in pkginfo
> 3) change "env" to "env -" for Makefile.sfw which will make a clear
> building environment
> 4) add METADATA to ruby18
>
> See http://cr.opensolaris.org/~chriszhu/CR6721879-webrev/ for all the
> update, please help to review.
From very quick skip through, this looks okay to me now. But see
comments below ...
> chris zhu wrote:
>> Paul Cunningham wrote:
... cut ...
>>> 4. usr/src/pkgdefs/SUNWruby18u/prototype_com
>>> & in SUNWruby18u/prototype_i386.tmpl
>>> & SUNWruby18u/prototype_sparc.tmpl
>>> The files (f ) delivered in /usr shouldn't really have
>>> the write permission bit set. You may want to change
>>> that with this update.
>> We will add it on the list of things to do in next update, but keep it
>> as it was at the moment.
That's okay with me - but the RTI process may pick it up
... cut ..
>>> 6. usr/src/cmd/ruby18/Makefile.sfw
... cut ..
>>> Christopher Mi wrote:
>>> > Use the method define in Makefile.master
>>> > since you have a standard METADATA file.
>>> >
>>> > VER =$(COMPONENT_NAME:sh)-$(COMPONENT_VERSION:sh)
>>> > TARBALL =$(VER).tar.bz2
>>>
>> It seems not work, so we define the TARBALL name by ourself.
That maybe because in your METADATA file there is ..
a) a space between the '6' and 'p' in "VERSION: 1.8.6 p287",
maybe it should be 1.8.6-p287
b) and ruby name is capitalized, eg "PROGRAM: Ruby"
but I'm just guessing.
>>> +
>>> Lines 124 & 125 and 107 & 108, do you really need to
>>> do these 'chmod's, if not remove them (might reduce
>>> build time a tiny bit).
>> I think it makes sure that all directory have the permission of 755,
>> and all users have the right to read files. Maybe it's not so
>> necessary, but I think it's a good habit to make sure that all the
>> files and directories extracted from the tar ball have basic
>> permission for building. So I just keep them as before.
okay with me - but seems a waste of build machine time if its not really
required.
Paul
... cut ...
--
----------------------------------------------------------------------
Paul Cunningham
Software Engineer
Tadpole Computer Products
