Hi Stefan, This looks mainly okay to be - but there are a few comments that you might want to consider, see below ....
Note, I haven't really looked at the CFLAGS/CCFLAGS changes, they are a bit of a blackart to me. Paul Stefan Teleman wrote: > http://cr.opensolaris.org/~steleman/6753392/ === Start of Comments ==== 1. usr/src/lib/ilmbase/Makefile.sfw & usr/src/lib/openexr/Makefile.sfw You might want to change the configure options stuff so its done in the following way (where CONFIGURE_OPTIONS is initially defined in Makefile.master), eg ... CONFIGURE_OPTIONS += --localstatedir=/var CONFIGURE_OPTIONS += --enable-shared etc ... ... ... ./configure $(CONFIGURE_OPTIONS) You might also want to tell configure what SHELL to use. And ... Mike.Sullivan at sun.com wrote: > > Makefile.sfw > you really should be using $(GTAR) and the --no-same-owner > option like others. 2. usr/src/lib/ilmbase/*.diff & usr/src/lib/openexr/*.diff These seem to be patching source that looks like it is owned by Sun, so why haven't the changes been added to that source directly and the pkg up-versioned (rather than patching it here)? 3. usr/src/lib/openexr/Makefile.sfw See comment 1. The current 'configure --prefix=' is '$(ROOT)/usr', doesn't that tell the build system to install it in the ws proto area and also that it's going run from there; shouldn't it be /usr (or $(CFGPREFIX)) === End of Comments ====== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Computer Products
