Hi,
> http://cr.opensolaris.org/~steleman/6753392/
* First of all, I know that Mike Sullivan has some workspace with fixes
for SS12. So it would be good to merge your work together.
* The compiler flags you used. That looks like revolution ! :) Before
going to details, I'm curious, why exactly this set ?
* After just quick observation of the flags, for example, why do you
explicitly link with "LDFLAGS = -lCrun -lCstd -lc ..." ? CC should
insert proper libraries, moreover in the correct order.
* ImfArray.h.1.diff
You use
33 +#if defined(__SUNPRO_C) || defined(__SUNPRO_CC)
34 +#include <sys/types.h>
35 +#include <limits.h>
36 +#endif
The macors __SUNPRO_C detects Sun compiler, but the <limits.h> include
file is required by Solaris system and not sun compiler. Would not be
cleaner to use (sun) or (__sun) ? (This applies to other include files also)
47 - ~Array () {delete [] _data;}
50 + ~Array() { delete[] _data;}
Unnecessary change ?
57 - operator T * () {return _data;}
58 - operator const T * () const {return _data;}
59 + inline operator T* () { return _data; }
60 + inline operator const T* () const { return _data; }
This was required by Sun Studio 12 ? Or is the fix doing some other
things ? (I remember I had some fight with inline operators in SS12, but
don't already remember what exactly ...)
Have you communicated with openexr community to include your fixes ?
> Thank you.
Thank you for your work
--
Vlad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 193 bytes
Desc: not available
URL:
<http://mail.opensolaris.org/pipermail/sfwnv-discuss/attachments/20080930/198990d2/attachment.bin>
