Paul Cunningham wrote: > >> http://cr.opensolaris.org/~steleman/6630180-6699388-6697908/ > > ==== Start of Comments ==== > > 1. usr/src/lib/lcms/Makefile.sfw > Why has '--with-python' changed to '--without-python' for > the 64 bit stuff? Shouldn't 32 & 64 bit have the same > functionality (add comment to say why not maybe).
There is no corresponding 64-bit vendor-packages directory for 64-bit Python (as per PSARC/2006/666), so 64-bit _lcms.so has no install directory. > 2. usr/src/lib/pcre/Makefile.sfw > and usr/src/lib/lcms/Makefile.sfw > In the definitions for 'sparcv9_CCFLAGS' & 'amd64_CCFLAGS' > why does '-compat=' use 5 rather than '$(COMPAT_VERSION)'? Will fix. > 3. usr/src/lib/pcre/install-sfw > + usr/src/lib/pcre/install-sfw-64 > Copyright year needs to be changed. > Shouldn't the 'mkdir -p' dirs be in 'Targetdirs' rather > than created here (this hasn't changed from original). It is in Targetdirs already -- will remove from install-sfw-64. Thank you very much! --Stefan -- Stefan Teleman Sun Microsystems, Inc. Stefan.Teleman at Sun.COM
