Chris, it looks good to me
paul Chris Zhu wrote: > Thanks for your advice, you're right, the default depend is enough for me. > The webrev is updated on > http://cr.opensolaris.org/~chriszhu/CR6704728-webrev/ > > > Paul Cunningham wrote: > >> >> >> Chris Zhu wrote: >> >>> >>> Please help to review the CR6704728 - Incorrect dependency list in >>> SUNWruby18r. >>> the webrev is ready on >>> http://cr.opensolaris.org/~chriszhu/CR6704728-webrev/. >> >> >> The content of your new 'depend' file looks like the default set (I >> think), if so why not just use the default depend? >> >> Note, I haven't got access the the 6704728 bug link, so I can't look >> at that to see what that says. >> > -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Computer Products General Dynamics Itronix Europe Ltd. Pioneer House Chivers Way Histon, Cambridgeshire, UK, CB24 9NL Ph: +44 (0)1223 200648 FAX: +44 870 4324162 Email: paul.cunningham at tadpole.com This email message is for the sole use of the intended recipient(s) and may contain GDC4S confidential or privileged information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not an intended recipient, please contact the sender by reply email and destroy all copies of the original message
