Joe, See my comments below ...
Paul Joe Blount wrote: > > I'm porting libmhash to opensolaris sfw, and would appreciate a code > review of my changes. libmhash is a library that provides interfaces to > several common hash algorithms and is used in many open source projects. > > > A webrev is available here: > > http://cr.opensolaris.org/~jblount/libmhash/ > === Start of Comments === 1. usr/src/lib/Makefile You might want to move your new entry up the list to be with the other 'lib*' entries and in alphabetical order (I know the list is not that well ordered). 2. usr/src/lib/libmhash/install-sfw I don't think 'ROOTMAN3DIR=' is used, if not delete. Someone else pointer out that defining 'MANSCRIPT=../sunman-stability' is not required anymore. Check and if not remove. 3. usr/src/pkgdefs/SUNWmhash/prototype_com The 'test' entries that are commented out are installed by install-sfw*, doesn't this cause a build error of the whole ws saying that there are unpackaged files? 4. Everything else looks okay to me === End of Comments ===== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Computer Products
