Joe,
Additional comments ...
Paul
=== Start of comments ===
1. usr/src/pkgdefs/SUNWmhash/depend
Copyright year is wrong.
Move Copyright lines to after the "CDDL HEADER END"
header.
2. usr/src/lib/libmhash/install-sfw
This still includes (see item 2 below) ..
'MANSCRIPT=../sunman-stability'
Is this required?
=== End comments ========
On Wed, 2008-06-04 at 16:07, Joe Blount wrote:
> Sorry for the delay, an updated webrev is now posted.
>
>
> Paul's changes below are done, also:
>
>
> depend file:
> Removed use of default depend (DATAFILES = depend)
> Added depend file with default + SUNWgccruntime
>
> Thanks for the feedback!
> Joe
>
> Paul Cunningham wrote:
> > Joe,
> >
> > See my comments below ...
> >
> > Paul
> >
> > Joe Blount wrote:
> >>
> >> I'm porting libmhash to opensolaris sfw, and would appreciate a code
> >> review of my changes. libmhash is a library that provides interfaces
> >> to several common hash algorithms and is used in many open source
> >> projects.
> >>
> >> A webrev is available here:
> >>
> >> http://cr.opensolaris.org/~jblount/libmhash/
> >>
> >
> > === Start of Comments ===
> >
> > 1. usr/src/lib/Makefile
> > You might want to move your new entry up the list to be with the
> > other 'lib*' entries and in alphabetical order (I know the list is
> > not that well ordered).
> done
> >
> > 2. usr/src/lib/libmhash/install-sfw
> > I don't think 'ROOTMAN3DIR=' is used, if not delete.
> > Someone else pointer out that defining
> > 'MANSCRIPT=../sunman-stability' is not required anymore.
> > Check and if not remove.
> removed.
> >
> > 3. usr/src/pkgdefs/SUNWmhash/prototype_com
> > The 'test' entries that are commented out are installed by
> > install-sfw*, doesn't this cause a build error of the whole
> > ws saying that there are unpackaged files?
> I commented them out in prototype_com
>
> >
> > 4. Everything else looks okay to me
> >
> > === End of Comments =====
> >
> >
> _______________________________________________
> sfwnv-discuss mailing list
> sfwnv-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss
