7. usr/src/cmd/swig/swig.1 Did you write this? If not did it come out of The tarball? If so why aren't you using straight Out of the tarball rather than having a private copy?
swig does not have a man page. I created this one to point to the online documentation that swig has. Is there a problem with this? Bruce Cunningham, Paul - UK wrote: > Bruce, > > See below for my comments from my *quick* skip through ... > > Paul > > >> -----Original Message----- >> From: sfwnv-discuss-bounces at opensolaris.org [mailto:sfwnv-discuss- >> bounces at opensolaris.org] On Behalf Of Bruce Rothermal >> Sent: 23 June 2008 23:42 >> To: sfwnv-discuss at opensolaris.org >> Subject: [sfwnv-discuss] Request for code review - swig utility >> >> Please see http://cr.opensolaris.org/~bruce_r/swig/ and provide any >> comments or changes I need to make. >> > > === Start of Comments === > > 1. usr/src/cmd/Makefile > & usr/src/Targetdirs > & usr/src/pkgdefs/Makefile > It looks as though this need resyncing with the gate otherwise > It looks as though you are deleting stuff. > > 2. usr/src/cmd/swig/Makefile.sfw > You have hard coded '--prefix=...' , you might > want to use the predefined value in CONFIGURE_OPTIONS, > see > http://cr.opensolaris.org/~rayx/erlang/webrev/usr/src/cmd/erlang/Makefil > e.sfw.html > > 3. usr/src/pkgdefs/SUNWswig/pkginfo > You should have checked in the pkginfo.tmpl version > Of this only; as this is created by the build system > > 4. usr/src/pkgdefs/SUNWswig/prototype_com > & usr/src/pkgdefs/SUNWswig/prototype_i386 > & usr/src/pkgdefs/SUNWswig/prototype_sparc > Copyright year and the format of the lines are wrong > > 5. usr/src/Targetdirs > Your added stuff doesn't look aligned with the other > Lines in the file > > 6. usr/src/cmd/swig/install-swig > & usr/src/pkgdefs/SUNWswig/Makefile > & usr/src/pkgdefs/SUNWswig/pkginfo.tmpl > & check all the others > Copyright year is wrong > > 7. usr/src/cmd/swig/swig.1 > Did you write this? If not did it come out of > The tarball? If so why aren't you using straight > Out of the tarball rather than having a private copy? > > 8. usr/src/pkgdefs/SUNWswig/depend > The Makefile says you are using the default 'depend' > File, and this looks like that default file. So you > Don't need this file checked in. > > 9. usr/src/pkgdefs/SUNWswig/pkginfo.tmpl > 'VERSION=' line is not correct > > === End of Comments ===== > -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.opensolaris.org/pipermail/sfwnv-discuss/attachments/20080624/6a7a91c7/attachment.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: bruce_rothermal.vcf Type: text/x-vcard Size: 305 bytes Desc: not available URL: <http://mail.opensolaris.org/pipermail/sfwnv-discuss/attachments/20080624/6a7a91c7/attachment.vcf>
