Thanks for taking time for review. My comments inlined:
paulcun at talk21.com wrote:
> Some comments ...
>
> --- Maxim Kartashev <Maxim.Kartashev at Sun.COM> wrote:
>
>
>> And here's a copy visible for everyone:
>> http://cr.opensolaris.org/~perezzz/cvs.webrev/
>>
>
> 1. MINOR pkgdefs/SUNWcvs/depend
> Shouldn't the 'copyright' statement be after the
> 'CDDL Header'
>
I don't really know if it matters. SUNWp7zip (which I used as a
template) has the same ordering of CDDL header and copyright information.
> 2. pkgdefs/SUNWcvs/prototype_com
> Shouldn't the 'man' page bits be in a seperate
> package
>
No, man pages always comes with the binary.
> 3. cmd/cvs/install-cvs
> Does 'MANSCRIPT' get used ?
>
Yes, by ${SRC}/tools/install.subr
> Otherwise it looks okay to me
>
> Paul
>
> _______________________________________________
> sfwnv-discuss mailing list
> sfwnv-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss
>
