On Fri, Oct 19, 2007 at 07:41:34AM -0700, Martina Tomisova wrote:
> http://cr.opensolaris.org/~martina/vim/
FWIW, it looks like there are now 145 patches to 7.1. You might also just
use the 7.1.001-100.gz file that's there, save on a bit of webrev space.
For that matter, you could also just concatenate *all* the patches together
in a single file.
A general comment -- could you put a space between the comment leader and
the "ident" token on ident lines? Since it's not a compiler pragma in
shell scripts and makefiles, it should look like any other comment.
Makefile.sfw:
- line 35: I'm pretty sure Mike won't want this. You should just apply
all the patches in the directory, and remove the ones you don't want to
apply if you need to.
- line 61: can you confirm that this doesn't auto-detect python and perl
and the other languages, compiling in those bindings?
I would also suggest --with-features=huge, which turns on a bunch of
things that don't introduce dependencies, but are still nice to have.
install.sfw:
- You seem to be missing the part where you install everything.
solaris.patch:
- You ought to be able to set MANDIR via --mandir= on the configure line.
pkginfo.tmpl:
- I might include "(Vi IMproved)" in both NAME and DESC. I imagine most
people will know, but somehow it feels more in the right spirit.
prototype_com:
- You need a copyright file in here, containing the vim license
Danek
