Roland,
> Just curious: Why is "env" used in this case (I can't imagine a reason
> since $ FOO=bar application # and $ env FOO=bar application # are more
> or less identical in this situation) ?
Just following the precedent from virtually all the other Makefile.sfw files.
> Generic issue: Is the script really only called from with the Makefile ?
> If not (or in the case you want to be on the "safe" side please set PATH ...
Yes, these scripts are only called from the Makefile, so PATH should
not need to be set.
> Nit: Quotes around variable expansions are missing (e.g. $ mv
> "/a/${foo}" /a/x # instead of $ mv /a/${foo} /a/x #) ... (not mandatory
> if you are sure that the matching variables don't contain garbage by
> accident (which may let the script run&&jump amok...))
In this case, the vars all have known, simple values, so quoting
is not necessary.
I've implemented all your other suggestions, including the CC options. I also
changed to ksh93, as ksh doesn't support "source". New webrev:
http://cr.opensolaris.org/~dermot/tcltk64-04/
Thanks,
- Dermot
This message posted from opensolaris.org
