Dermot McCluskey wrote:
> Roland,
>
>> Just curious: Why is "env" used in this case (I can't imagine a reason
>> since $ FOO=bar application # and $ env FOO=bar application # are more
>> or less identical in this situation) ?
>
> Just following the precedent from virtually all the other Makefile.sfw files.
I'd be happy to know otherwise, but iirc it's so that things like
'configure' will see them in the environment as they run and alter
their behaviour (they won't see Makefile variables like 'CC' and
such otherwise).
It's also possible that they can be used to override the behavior
of the Makefiles created by configure too - though it's more likely
that the configure target is just being copied over and not trimmed
down to only what was needed. I think in the past I tried to trim
some down and then got failures so I just decided to stop and live
with a bit of replication :)
> I've implemented all your other suggestions, including the CC options.
So I will just point out, since I remember seeing Roland asking for
/opt/SUNWspro/bin/cc to be used, please not to hardcode
/opt/SUNWspro/bin/cc and instead use $(CC) to pick up what is
set by Makefile.master. And yes I saw you did the right thing in
the webrev I just wanted to make sure I pointed out the issue :)
I'd also prefer those new options to be in Makefile.master as
well - perhaps as new individual variables, so they can be
easily adjusted if they change on compiler updates without having
to update every Makefile in the gate. There could also be a
variable that combines them all if you like, though I can't
think of any other name right now than ROLANDS_KSH_OPTIONS :)
Mike
