Hi,
> The correct workspace was identified and a new webrev has been
> generated for your review. For all of those who are able and
> interested, please examine the following webrev:
>
> http://cr.opensolaris.org/~patb/pmtools_webrev/
* needs resync (as stated by Paul already)
* Makefile.sfw:46
46 INSTALL_ROOT=$(ROOTBIN) \
47 DESTDIR=$(ROOTBIN) \
That does not sound right at first look. DESTDIR is used as sort of
prefix. So if ROOTBIN is usr/bin, and program would install binary into
usr/bin/mybinary, result would be in /usr/bin/usr/bin/mybinary. But I
guess you tested this, so you know it works correctly. Just suspicious.
* Makefile.sfw:48
48 MAKE=$(GMAKE) \
This should not be necessary, as make/gmake sets this variable
automatically, so that it points to itself.
* Makefile.sfw:66
66 -rm -rf $(VER)
Should be $(RM) -r $(VER) ( see Makefile.master )
* pmtools-01.patch
* New man pages
- Any chance of pushing the changes to the original authors?
Just nits really
Thank you
--
Vlad
