Hi,
>> * Makefile.sfw:46
>> 46 INSTALL_ROOT=$(ROOTBIN) \
>> 47 DESTDIR=$(ROOTBIN) \
>>
>> That does not sound right at first look. DESTDIR is used as sort of
>> prefix. So if ROOTBIN is usr/bin, and program would install binary
>> into
>> usr/bin/mybinary, result would be in /usr/bin/usr/bin/mybinary. But I
>> guess you tested this, so you know it works correctly. Just
>> suspicious.
>>
> I understand your point. I was following another example and it works,
> so disinclined to change it right now.
Fair enough.
>> * Makefile.sfw:66
>> 66 -rm -rf $(VER)
>>
>> Should be $(RM) -r $(VER) ( see Makefile.master )
> I thought about that too, but again, it looked like this in other
> instances. I'm not opposed to making this change if it's appropriate.
This would be nice touch to keep it with sync with other changes
happening in sfwnv. Please do this (silly) change.
>> * pmtools-01.patch
>> * New man pages
>> - Any chance of pushing the changes to the original authors?
> The patch came from one of the original developers of these utilities
> and I ran the man pages past him too and he thought they looked good.
I see.
> I don't intend to put these man pages anywhere besides SUNWpmtools. ;)
Well, the less deviations from the official tree, the better for us ...
Let's see if others have something to add.
Thanks for your effort, I don't have further comments.
--
Vlad
