You overwrote the sfwnv_p version of the webrev so I can't see what's
changed since the last time I reviewed it.
1. usr/src/pkgdefs/SUNWfreeipmir/Makefile
You have 'depend' listed under DATAFILES, this will pull in the default
depend file at build time and probably overwrite yours.
2. usr/src/pkgdefs/SUNWfreeipmir/depend
Out of curiousity, why does the Root package need to depend on SUNWesu?
If it's an absolute requirement for freeipmi then shouldn't it be a
dependency for the Usr package?
3. usr/src/cmd/freeipmi/Makefile.sfw
you've removed the bmi_intf.h from the workspace but haven't removed
${SRC}/cmd/freeipmi from the include path in $(CPPFLAGS).
4. usr/src/cmd/freeipmi/sunman-stability
bmc-config --checkout may not work properly because of Sun's BMC driver
issue.
bmc-device --get-lan-statistics may not work properly because of Sun's
BMC issue.
You need to add these to the "known issues" list, not just append them
to the bottom of the file, patch the man page files. Also the wording
"Sun's BMC driver issue" I don't think is going to fly. Try "issues with
some versions of the BMC driver" or something like that.
5. Where's the Source tarball? It seems to have gone missing
Amanda
Jan Forch wrote:
> Hi folks,
> please could someone do webrev for us. It is really urgent. We would
> like to be integrated into Fridays build. Thanks,
> Jan
>
> Webrev: http://cr.opensolaris.org/~jf222792/sfwnv_w/
