Hi Amanda, thanks for comments. Jan new webrev: http://cr.opensolaris.org/~jf222792/sfwnv_p
On 08/03/09 14:18, Amanda Waite wrote: > Jan Forch wrote: >> Hi, >> please we need new webrev ASAP due to changes related to application >> sunman-stability script on man pages outside of default man page >> directory. It affected man pages of other projects. >> Changes: >> >> Makefile.sfw: >> >> ++ CONFIGURE_OPTIONS += --mandir=/usr/share/man/tmp_freeipmi_man > BTW: You'll need a second reviewer. I know but no one other has answered yet. > > > It looks like you've solved the problem but I'm not sure that the > proto_area is the right place for your tmp_freeipmi_man directory. The > likes of samba and fastcgi create a temporary directory in the > components workspace dir, maybe $SRC/cmd/freeipmi/prototmp FIXED TO: CONFIGURE_OPTIONS += --mandir=$(SRC)/cmd/freeipmi/prototmp/usr/share/man/tmp_freeipmi_man > > Also, I noticed this: > > CONFIGURE_OPTIONS_64 += --libdir=/usr/lib/amd64 > > Which I guess hasn't been picked up on before? Basically your SPARC > package will deliver 64-bit libraries to /usr/lib/amd64 which might > work for your binaries, but probably will break lots of other stuff. > You need to change the above line to: > > CONFIGURE_OPTIONS_64 += --libdir=/usr/lib/$(MACH64) FIXED > > and then in the package you need to list the 64-bit binaries in > prototype_sparc and prototype_i386 using the architecture specific > paths, something like: > > s none usr/lib/sparcv9/libipmidetect.so=libipmidetect.so.0.0.0 > s none usr/lib/sparcv9/libipmidetect.so.0=libipmidetect.so.0.0.0 > f none usr/lib/sparcv9/libipmidetect.so.0.0.0 0755 root bin > ... > ... > > for prototype_sparc and > > s none usr/lib/amd64/libipmidetect.so=libipmidetect.so.0.0.0 > s none usr/lib/amd64/libipmidetect.so.0=libipmidetect.so.0.0.0 > f none usr/lib/amd64/libipmidetect.so.0.0.0 0755 root bin > ... > ... > > for prototype_i386 > FIXED > Amanda >> >> >> install.sfw: >> please check whole file >> >> webrev presentation: http://cr.opensolaris.org/~jf222792/sfwnv_p >> >> Thank you >> Jan Forch >> >
