This mainly looks good to me, a few more comments below ... paul
Gowtham T wrote: > > I have updated the webrev with the ARC and OSR details. It can be found at > > http://cr.opensolaris.org/~tgowtham/gutenprint > > Can some one please review the changes and complete the review? >>> Gowtham T wrote: >>>> >>>> I have posted the webrev for the gutenprint(formerly called >>>> gimp-print) upgrade to latest community version 5.2.4. >>>> Can some one please review the below changes? >>>> >>>> http://cr.opensolaris.org/~tgowtham/gutenprint/ >>>> >>>> Some of the changes are done because of the name change done to the >>>> package/utility from gimp-print to gutenprint. 1. usr/src/pkgdefs/SUNWgutenprint/copyright Does this neeed the 'Sun disclaimer' stuff added? And the source owner copyright statements ? 2. usr/src/pkgdefs/SUNWgutenprint/prototype_com Lots of the files still have the write-permission bit set - should these be removed now? 3. various files This is being a bit picky, but a number of the files has double # lines at the top which should really be a single #, eg. ... # # # ....... should be ... # # ....... 4. usr/src/pkgdefs/SUNWgutenprint/pkginfo.tmpl You could put the version number on the DESC= line in brackets, eg ..... DESC="................... (5.2.4)" -- Paul Cunningham Software Engineer
