Paul, Paul Cunningham wrote: > This mainly looks good to me, a few more comments below ... > > paul > > Gowtham T wrote: >> >> I have updated the webrev with the ARC and OSR details. It can be >> found at >> >> http://cr.opensolaris.org/~tgowtham/gutenprint >> >> Can some one please review the changes and complete the review? > 1. usr/src/pkgdefs/SUNWgutenprint/copyright > Does this neeed the 'Sun disclaimer' stuff added? > And the source owner copyright statements ? This file has been taken from the Gutenprint source tar directly. I don't think it requires a Sun disclaimer and owner. I have checked with other copyright files. > > 2. usr/src/pkgdefs/SUNWgutenprint/prototype_com > Lots of the files still have the write-permission bit > set - should these be removed now? The file permissions have been derived from the built proto area. I am not sure if we need to change the permissions after the build. > > 3. various files > This is being a bit picky, but a number of the files > has double # lines at the top which should really be a > single #, eg. ... > # > # > # ....... > should be ... > # > # ....... I will correct them. > > 4. usr/src/pkgdefs/SUNWgutenprint/pkginfo.tmpl > You could put the version number on the DESC= line > in brackets, eg ..... > DESC="................... (5.2.4)" Done.
I will update the webrev and post it after I make some other changes. Regards, Gowtham > >
