See comments below ... paul
Spoorthy H.S wrote: > Please review. The new webrev is at > http://cr.opensolaris.org/~spoorthy/ws_cryptdes3/ > > I am porting the package Crypt-DES. This is the dependent package for > Crypt-CBC. The information about the package can be found at > http://search.cpan.org/dist/Crypt-DES/ > The webrev is at http://cr.opensolaris.org/~spoorthy/ws_cryptdes1/. Can > somebody have a look at this and review the same. 1. usr/src/Targetdirs It looks as though you are trying delete stuff that I don't think you intend to - file probably needs resyncing with gate/clone. 2. usr/src/lib/perl_crypt_des/METADATA Keep the lines in the same order as in ... http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines Is there a better web-page for PROJECT_URL:, the one you have doesn't seem very informative? What licence is actually used .. 4 LICENSE: Others ?? 3. usr/src/lib/perl_crypt_des/Makefile.sfw Line ... 32 CONFIGURE_OPTIONS+=... is this used, if not remove it 4. usr/src/lib/perl_crypt_des/install-sfw Lines 43 to 45 don't set the write-permission bit; also should they have the execute bit set? But I don't think you will deliver these any now anyway. 5. usr/src/pkgdefs/SUNWperl-crypt-des/depend Move copyright lines down to after the CCDL header. Fix the copyright year. SCCS ident line is wrong 6. usr/src/pkgdefs/SUNWperl-crypt-des/prototype_com Lines 58 to 60, see item 4 above -- Paul Cunningham Software Engineer Tel:
