Amanda & Paul, Thanks for the comments, although I think they are cleanup-as-you-go items rather than issues related to this particular bug.
In any event, I've implemented your suggestions and have a new webrev here: http://cr.opensolaris.org/~dermot/readline-curses-02/ Please let me know if you have any further comments. Thanks, - Dermot On 09/10/09 13:14, Amanda Waite wrote: > You could build $(VER) from the METADATA > > VER = $(COMPONENT_NAME:sh)-$(COMPONENT_VERSION:sh). > > Do you actually need those find statements? I know there's been debate > about this in the past, but I wouldn't have them there until it was > established that they were really needed, maybe you've already done that. > > Where you use 'env' use 'env -' instead so as to start with a clean > environment. > > You can use $(GINSTALL) in place of the full path to ginstall. > > Amanda > > > > Dermot McCluskey wrote: >> Please review this simple code change to readline: >> >> http://cr.opensolaris.org/~dermot/readline-curses-01/ >> >> 6846369 libreadline should not link against /lib/libcurses.so.1 >> >> >> (libreadline should not link to any specific curses lib - >> the app linking to libreadline should decide which curses >> lib it wishes to link against.) >> >> >> Thanks, >> - Dermot >> _______________________________________________ >> sfwnv-discuss mailing list >> sfwnv-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss >
