Looks mainly okay to me to; but you could use the '--prefix=' stuff from
Makefile.master, eg. either ...
./configure $(CONFIGURE_OPTIONS)
or ..
./configure --prefix=$(CFGPREFIX)
Also, I know you haven't changed them but install-sfw and install-sfw-64
could use the VERS= info passed in from this Makefile.sfw (ie. VER & VER64)
Paul
Dermot McCluskey wrote:
>
> Thanks for the comments, although I think they are cleanup-as-you-go
> items rather than issues related to this particular bug.
>
> In any event, I've implemented your suggestions and have a
> new webrev here:
> http://cr.opensolaris.org/~dermot/readline-curses-02/
>
> Please let me know if you have any further comments.
>>
>>
>> Dermot McCluskey wrote:
>>> Please review this simple code change to readline:
>>>
>>> http://cr.opensolaris.org/~dermot/readline-curses-01/
>>>
>>> 6846369 libreadline should not link against /lib/libcurses.so.1
>>>
>>>
>>> (libreadline should not link to any specific curses lib -
>>> the app linking to libreadline should decide which curses
>>> lib it wishes to link against.)
