On 09/22/09 11:28 AM, Spoorthy H.S wrote: > > Hi , > > I am porting the package Crypt-OpenSSL-AES. This is the dependent > package for Crypt-CBC. The webrev is at > http://cr.opensolaris.org/~spoorthy/opensslaes1/ . This uses default > perl 5.8.5 higher version. Please review the same ..
General: I think "SUNWperl-crypt-openssl-aes" is a better package name than "SUNWperl-crypt-opensslaes". There are a bunch of places that need to change - I won't list them all. usr/src/lib/perl_crypt_openssl_aes/METADATA:3 DESCRIPTION can probably be improved. Take a look at the description from http://search.cpan.org/~ttar/Crypt-OpenSSL-AES-0.02/lib/Crypt/OpenSSL/AES.pm usr/src/lib/perl_crypt_openssl_aes/METADATA:4 LICENSE looks wrong. Is this really GPLv2? GPLv2 is generally not allowed for libraries in Solaris. usr/src/lib/perl_crypt_openssl_aes/METADATA:6 A better pointer to the project would probably be: http://search.cpan.org/~ttar/Crypt-OpenSSL-AES-0.02/ usr/src/lib/perl_crypt_openssl_aes/METADATA:8 Is this correct? Contact me of sfw-discuss about this. usr/src/lib/perl_crypt_openssl_aes/Makefile.sfw:32 This should be removed. usr/src/lib/perl_crypt_openssl_aes/install-sfw:31 This line is x86 specific. The install script has to work for SPARC as well. usr/src/lib/perl_crypt_openssl_aes/install-sfw:38 I'm not totally sure what the .bs file is but it definitely isn't a perl script. You should install this as 'N'. usr/src/lib/perl_crypt_openssl_aes/install-sfw:39 This should be delivered as 'D'. usr/src/lib/perl_crypt_openssl_aes/sunman-stability:26 Change "perl_crypt_openssl_aes" to "Crypt::OpenSSL::AES". usr/src/pkgdefs/SUNWperl-crypt-opensslaes/pkginfo.tmpl:34 NAME could be improved. usr/src/pkgdefs/SUNWperl-crypt-opensslaes/pkginfo.tmpl:39 "user" should be "usr" usr/src/pkgdefs/SUNWperl-crypt-opensslaes/prototype_com:52-58 These lines belong in the x86 prototype file. usr/src/pkgdefs/SUNWperl-crypt-opensslaes/prototype_sparc You're missing the SPARC files. -M
