Spoorthy, Below are a few comments ...
Paul Spoorthy H.S wrote: > > I am porting the package Crypt-OpenSSL-AES. This is the dependent > package for Crypt-CBC. The webrev is at > http://cr.opensolaris.org/~spoorthy/opensslaes1/ . This uses default > perl 5.8.5 higher version. Please review the same .. 1. usr/src/lib/perl_crypt_openssl_aes/METADATA Would the following link be a better value for PROJECT_URL: ? ... "http://search.cpan.org/~ttar/Crypt-OpenSSL-AES/lib/Crypt/OpenSSL/AES.pm"; 2. usr/src/pkgdefs/SUNWperl-crypt-opensslaes/copyright Should this have the Sun Disclaimer statement added, and also the source owner copyright statements ? 3. usr/src/lib/perl_crypt_openssl_aes/Makefile.sfw Line 32, should you be hard coding this path PERL= ? what about builds on sparc. 4. usr/src/lib/perl_crypt_openssl_aes/install-sfw Lines 38-40, s the 'P' option the correct one to use "_install P" (# Install perl script file)? 5. usr/src/pkgdefs/SUNWperl-crypt-opensslaes/prototype_com Lines 56-58, should these have the write permission bit set (see install-sfw)? Lines 52-58, should these be in the architecture specific prototype_* files? END
