I haven't see any response to my comments on the subversion webrev of
this yet?
And here are some comments on the 'neon' bit (I didn't look at before),
quick skip through ...
1. usr/src/lib/libneon/Makefile.sfw
You should extract the VER= info from the METADATA now.
and then pass it into libneon/install-sfw for it to use.
Line 123 & 149, use the predefined --prefix= value from
Makefile.master
Why isn't --enable-webdav in the 64 bit configure as its
in the 32 bit ?
Lines 124-135 (!127) & 152-162 are nearly the same, so why not
set them just once, ie. ...
CONF_OPT= .... \
.... \
etc.
and use ./configure ..... \
............ \
$(CONF_OPT) \
2. usr/src/lib/libneon/install-sfw
& usr/src/lib/libneon/install-sfw-64
Don't deliver files with the write-permission bit set into /usr
Add 'set -o errexit' so it stops at first error
Pass in VERS= info from Makefile.sfw (rather than hard code it)
3. usr/src/pkgdefs/SUNWneon/prototype_com
& usr/src/pkgdefs/SUNWneon/prototype_i386
& usr/src/pkgdefs/SUNWneon/prototype_sparc
Don't deliver files with the write-permission bit set into /usr
4. SUNWneon/copyright
You have changed the licence in the METADATA, so should
this have changed also?
5. Bug Report 6751764
This should probably be updated to say you are upgrading
'neon' at the same time!
http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=6751764
END
Paul
Stefan.Teleman at sun.com wrote:
> ______________________________________________________________________________
>
> *Gate Info*:
> ______________________________________________________________________________
>
> RTI: 336623
> Gates: sfwnv
> Type: Marketing Release
> Consolidation: sunfreeware
>
> http://webrti.sfbay.sun.com/rti/view.php?consolidation=sunfreeware&r=336623
>
> ______________________________________________________________________________
>
> *Status Info*:
> ______________________________________________________________________________
>
> ### sfwnv Gate ###
>
> State: Submitted
>
>
> ______________________________________________________________________________
>
> *General Info*:
> ______________________________________________________________________________
>
> ### Common (Gates: sfwnv) ###
>
> Approved: (Not Yet Approved)
> Evaluator: David.Comay at Sun.COM
> CTE Escalation #: None
> Patch Requestor: None
> Code Reviewed By: paulcun at talk21.com
> MailCC: Stefan.Teleman at Sun.COM Fred.Thornborrow at
> Sun.COM
>
> ______________________________________________________________________________
>
> *CR (Bug) IDs*:
> ______________________________________________________________________________
>
> ### Common (Gates: sfwnv) ###
>
> Security Bug: No
>
> Responsible Engineers: stefan.teleman at sun.com (6751764)
>
> Bugid P S Impact Risk Synopsis:
>
> 6751764 3 4 2,o 2 Upgrade Subversion to 1.6.3
>
>
> ______________________________________________________________________________
>
> *ARC Case*:
> ______________________________________________________________________________
>
> ### Common (Gates: sfwnv) ###
>
> [empty]
> ______________________________________________________________________________
>
> *putback -n*:
> ______________________________________________________________________________
>
> ### sfwnv Gate ###
>
> Machine Name and Source Path for each gate:
>
> mogo.sfbay.sun.com:/builds1/steleman/sfwnv-svn/
> spidey.sfbay.sun.com:/builds/steleman/sfwnv-svn/
>
> putback -n output:
>
> Parent workspace: /ws/sfwnv-gate
> Child workspace: /builds1/steleman/sfwnv-svn
>
> cd /ws/sfwnv-gate/usr; /ws/onnv-tools/teamware/bin/def.dir.flp &
> cd /builds1/steleman/sfwnv-svn/usr; /ws/onnv-tools/teamware/bin/def.dir.flp
>
> Examined files: 5717
>
> Would put back contents changes: 19
> Would put back name changes: 11
>
> update: usr/src/Targetdirs
> update: usr/src/cmd/subversion/METADATA
> update: usr/src/cmd/subversion/Makefile.sfw
> update: usr/src/lib/libneon/METADATA
> update: usr/src/lib/libneon/Makefile.sfw
> update: usr/src/pkgdefs/SUNWneon/pkginfo.tmpl
> update: usr/src/pkgdefs/SUNWneon/prototype_com
> update: usr/src/pkgdefs/SUNWneon/prototype_i386
> update: usr/src/pkgdefs/SUNWneon/prototype_sparc
> update: usr/src/pkgdefs/SUNWsvn/pkginfo.tmpl
> update: usr/src/pkgdefs/SUNWsvn/prototype_com
> update: usr/src/pkgdefs/SUNWsvn-python/prototype_com
> create: usr/src/cmd/subversion/install-sfw
> create: usr/src/cmd/subversion/subversion-1.6.5.patch
> create: usr/src/cmd/subversion/subversion-1.6.5.tar.gz
> create: usr/src/cmd/subversion/sunman.sed
> create: usr/src/lib/libneon/install-sfw
> create: usr/src/lib/libneon/install-sfw-64
> create: usr/src/lib/libneon/neon-0.29.0.tar.gz
> rename from: usr/src/cmd/subversion/subversion-1.4.3.patch
> to: deleted_files/usr/src/cmd/subversion/subversion-1.4.3.patch
> rename from: usr/src/cmd/subversion/subversion-1.4.3.tar.gz
> to: deleted_files/usr/src/cmd/subversion/subversion-1.4.3.tar.gz
> rename from: usr/src/cmd/subversion/sunman/svn.1.sunman
> to: deleted_files/usr/src/cmd/subversion/sunman/svn.1.sunman
> rename from: usr/src/cmd/subversion/sunman/svnadmin.1.sunman
> to: deleted_files/usr/src/cmd/subversion/sunman/svnadmin.1.sunman
> rename from: usr/src/cmd/subversion/sunman/svndumpfilter.1.sunman
> to:
> deleted_files/usr/src/cmd/subversion/sunman/svndumpfilter.1.sunman
> rename from: usr/src/cmd/subversion/sunman/svnlook.1.sunman
> to: deleted_files/usr/src/cmd/subversion/sunman/svnlook.1.sunman
> rename from: usr/src/cmd/subversion/sunman/svnserve.8.sunman
> to: deleted_files/usr/src/cmd/subversion/sunman/svnserve.8.sunman
> rename from: usr/src/cmd/subversion/sunman/svnserve.conf.5.sunman
> to:
> deleted_files/usr/src/cmd/subversion/sunman/svnserve.conf.5.sunman
> rename from: usr/src/cmd/subversion/sunman/svnsync.1.sunman
> to: deleted_files/usr/src/cmd/subversion/sunman/svnsync.1.sunman
> rename from: usr/src/cmd/subversion/sunman/svnversion.1.sunman
> to: deleted_files/usr/src/cmd/subversion/sunman/svnversion.1.sunman
> rename from: usr/src/lib/libneon/neon-0.25.5.tar.gz
> to: deleted_files/usr/src/lib/libneon/neon-0.25.5.tar.gz
>
> Examined files: 5717
>
> Contents Summary:
> 7 create
> 12 update
> 5698 no action (unchanged)
>
> Names Summary:
> 11 renamed
>
> No changes were put back
>
>
> ______________________________________________________________________________
>
> *Comments*:
> ______________________________________________________________________________
>
> ### Common (Gates: sfwnv) ###
>
>
> ** [Fri Sep 25 17:30:00 PDT 2009] [state=S_SUBMITTED submitter=Stefan.Teleman
> at Sun.COM] **
>
> SPARC build is still running will finish later on Friday 2009/09/25.
>
> WEBREV:
>
> http://cr.opensolaris.org/~steleman/6751764/
>
>
>
> ______________________________________________________________________________
>
> *Test Results*:
> ______________________________________________________________________________
>
> ### Common (Gates: sfwnv) ###
>
> Ran gmake check test harness on all4 ISA's for libneon.
> Pass as expected *PROVIDED* /usr/gnu/bin is at the head of $PATH.
> The test harness assumes the GNU version of these userland commands.
>
> Ran gmake test test harness on all 2 ISA's for subversion.
>
> Pass if:
>
> 1. PATH points to the proto build area, followed by /usr/gnu/bin.
> 2. LD_LIBRARY_PATH points to the proto build area.
> 3. PYTHONPATH points to the proto build area.
>
> We do not deliver a 64-bit subversion.
>
> ______________________________________________________________________________
>
> *Additional Info*:
> ______________________________________________________________________________
>
> ### Common (Gates: sfwnv) ###
>
> License Information for Open Source Software:
> ---------------------------------------------
>
> LIBNEON:
>
> License Name: LGPL Version 2
> Legal Review Number: OSR #4499.
> Minor change, new legal review not required: YES.
>
> SUBVERSION:
>
> License Name: Subversion
> Legal Review Number: OSR #4495
> Minor change, new legal review not required (Y/N): Y.
>
