Stefan Teleman wrote: > Paul Cunningham wrote:
... cut ... > >> 2. usr/src/lib/libneon/install-sfw >> & usr/src/lib/libneon/install-sfw-64 >> Don't deliver files with the write-permission bit set into /usr > > OK, i can't do this either. Both libneon and subversion were originally > integrated with the permissions set as you see them right now. If i > change the permissions, there will be complaints from protocmp, and that > will evolve into someone else complaining about the complaints from > protocmp. Either way, someone will complain. > > As it is right now, permissions bits remain identical with the previous > (original) integration. That avoids pointless complaints at the bottom > of nightly.log, and also avoids another round of conversations about why > is protocmp complaining about file permission bits, when protocmp > shouldn't be complaining about file permission bits. > > And this is a very good illustration of why code reviews should perhaps > avoid dealing with stylistic preferences which aren't really > standardized anywhere, but are merely, and mostly, a matter of personal > preference. > > If there really was an interdiction about not delivering 0644 header > files under /usr, then the previous integration would not have happened > with the currently existing permissions, or it would have been corrected > sometime between 2006 and now, or someone would at least have filed a CR > about wrong permission bits for libneon and subversion header files. > None of this happened. > > I also see a whole bunch of header files with permission 0644 under > /usr/include/*.h, and subdirectories. Okay - but please remove me from your RTI reviewer list paul
