Amanda, Mainly looks good to me, but see comments below (mainly cosmetic) ...
Paul Amanda Waite wrote: > Thanks to Sriram for the review, is there anyone else that can look over > the lighttpd update for me? > > http://cr.opensolaris.org/~tekgrrl/CR6871404/ > > Amanda Waite wrote: >> >> I'm updating Lighttpd in SFW to v1.4.23 and would really appreciate it >> if you could review my code. The Webrev is here: >> >> http://cr.opensolaris.org/~tekgrrl/CR6871404/ >> >> Things to note are that as the Lighttpd source no longer bundles >> spawn-fcgi we've moved it into a separate package SUNWspawn-fcgi. As >> per the Arc Case (http://arc.opensolaris.org/caselog/LSARC/2009/562) >> we've maintained the old spawn-fcgi paths in the Lighttpd packages. 1. usr/src/cmd/lighttpd14/Solaris/lighttpd.1m.sunman I'm not sure you need the CDDL header on this anymore - refer to what Jim Walker said; but do check that. 2. usr/src/cmd/spawn-fcgi/Makefile.sfw Lines 67 & 68, could you have used just ... ?... ./configure $(CONFIGURE_OPTIONS) 3. usr/src/pkgdefs/SUNWlighttpd14u/prototype_com Lines 88-90, you could reorder so the two man8 lines are together ? Should the man8/lighttpd.8 also have a symbolic link in /usr/share/man ? 4. usr/src/pkgdefs/SUNWspawn-fcgi/copyright Maybe delete line 1 so there is only one line-space at the top
