Thanks Paul, update webrev at: http://cr.opensolaris.org/~tekgrrl/CR6871404/
Paul Cunningham wrote: > > 1. usr/src/cmd/lighttpd14/Solaris/lighttpd.1m.sunman > I'm not sure you need the CDDL header on this anymore - refer > to what Jim Walker said; but do check that. I don't think it does any harm so won't seek clarification and will leave it as it is if it's ok with you. > > 2. usr/src/cmd/spawn-fcgi/Makefile.sfw > Lines 67 & 68, could you have used just ... ?... > ./configure $(CONFIGURE_OPTIONS) Changed > > 3. usr/src/pkgdefs/SUNWlighttpd14u/prototype_com > Lines 88-90, you could reorder so the two man8 lines are > together ? I thought I'd get away with that one :o) Changed > > Should the man8/lighttpd.8 also have a symbolic link in > /usr/share/man ? No, the spawn-fcgi link is in the other direction, spawn-fcgi.1 is in /usr/share/man/man1 and we link to it to maintain the path that was in older versions of the lighttpd package. There's a lighttpd.1m in /usr/share/man but we left it to the user to use MANPATH to access the other pages > > 4. usr/src/pkgdefs/SUNWspawn-fcgi/copyright > Maybe delete line 1 so there is only one line-space > at the top Changed Thanks for the review Amanda
