Hi, Please code review the following change: http://cr.opensolaris.org/~aragorn/6826438-slang/
The fix contains following non-trivial changes: 1) usr/src/lib/slang/METADATA ----------------------------- According to http://www.opensolaris.com/learn/subscriptions/freeware/ and http://myspulin.czech.sun.com/osm/view/solarisrelease_s11_list/ the support level get changed from Managed (B) to Community (C). 2) usr/src/lib/slang/Makefile.sfw --------------------------------- 2.1) +# Options for configure script +CONFIGURE_OPTIONS += --sysconfdir=$(CFGETC)/slsh +CONFIGURE_OPTIONS += --with-pcre="$(ROOT)$(CFGPREFIX)" +CONFIGURE_OPTIONS += --with-pcreinc="$(ROOTINCLUDE)/pcre" +CONFIGURE_OPTIONS += --with-z="$(ROOT)$(CFGPREFIX)" + pcre and z are now used from the sfwnv gate instead of the installed system (build machine). 2.2) Removed all -L and -R settings in LDFLAGS (in both config.status targets; configure phase) because they are not needed. 2.3) Both install32 install64 do not set INSTALL macro now because the install program is correctly detected during the configure phase. 2.4) Added 'env -' for all relevant targets. This caused that "make install" now requires "-e" parameter, because the slang package sets DESTDIR to empty string (not correctly, IMHO) in its Makefile's. 3) usr/src/pkgdefs/SUNWslang/depend ----------------------------------- New rand-module.so requires libm.so.2. This introduced the SUNWlibms dependency. 4) usr/src/tools/post_process_so.ksh ------------------------------------ - newrpath=`echo ${rpath} | sed -e s,${ROOT},,` + newrpath=`echo ${rpath} | sed -e s,${ROOT},,g` Change in slang described in note 2.1 above caused that some libraries in slang got two paths with $(ROOT) into rpath. post_process_so was not able to remove/fix the second instance of it due to a bug in the sed script. Thanks for your time. -- Marcel Telka Solaris RPE
