Hi Vlad,

On Mon, Dec 14, 2009 at 04:20:44PM +0100, Vladimir Marek wrote:
> > Please code review the following change:
> > http://cr.opensolaris.org/~aragorn/6826438-slang/
> 
> Looks good to me.

Thanks!

> 
> > 4) usr/src/tools/post_process_so.ksh
> > ------------------------------------
> > 
> > -   newrpath=`echo ${rpath} | sed -e s,${ROOT},,`
> > +   newrpath=`echo ${rpath} | sed -e s,${ROOT},,g`
> > 
> > Change in slang described in note 2.1 above caused that some libraries in 
> > slang
> > got two paths with $(ROOT) into rpath. post_process_so was not able to
> > remove/fix the second instance of it due to a bug in the sed script.
> 
> I would consider separate CR for this.

If there is at least one more request for separate CR for this I'll
file it :-).


Thanks.

-- 
Marcel Telka
Solaris RPE

Reply via email to