Hi Paul, On Wed, Dec 23, 2009 at 12:56:06PM +0000, Paul Cunningham wrote: > Marcel, > > This mainly looks good to me, but see minor comments below ...
Thanks for the review. > 1. usr/src/pkgdefs/SUNWfetchmail/depend > You should probably move the "Copyright ..." lines to after > the 'CDDL HEADER END' header I'll do. > > 2. usr/src/pkgdefs/SUNWfetchmail/prototype_com > The new files probably shouldn't have the 'write' permission > bit set. I'll do too. > > 3. General > Depending when you are going to integrate this, you might want to > change the 'Copyright 2009' to 'Copyright 2010' I hope I'll integrate this year. If not, I'll update the copyright year. I am sure wx pbchk would complain :-). -- Marcel Telka Solaris RPE
