I did a quick skip through and this looks okay to me Paul
Marcel Telka wrote: > Hi, > > Is it better now? :-) > > Please read inlined... > > On Tue, Dec 22, 2009 at 07:58:41PM +0100, Marcel Telka wrote: >> Please code review fix for following CRs: >> >> 6825333 Update fetchmail to version 6.3.13 >> 6802880 Add NTLM support to fetchmail >> >> The webrev is available at: >> http://cr.opensolaris.org/~aragorn/6825333-fetchmail/ > > The updated webrev is at: > http://cr.opensolaris.org/~aragorn/6825333-fetchmail/ > > I left the previous webrev for reference at: > http://cr.opensolaris.org/~aragorn/6825333-fetchmail-1/ > >> The webrev contains following non-trivial changes: >> ----------------------------------------------- >> >> 1. Synchronized usr/src/pkgdefs/SUNWfetchmail/copyright file with COPYING >> file >> from the fetchmail-6.3.13 distribution. >> >> 2. Removed patch.configure file. This was only a temporary workaround until >> both PSARC/2007/635 and PSARC/2007/634 are integrated (see CR 6696871 for >> more >> info). The integration happened in build 92 (covered by CR 6627387). >> >> 3. Removed fetchmail-6.3.8-CVE-2007-4565.patch file. This is already >> integrated >> into upstream fetchmail sources. >> >> 4. Added NTLM support (--enable-NTLM in Makefile.sfw). This is CR 6802880. >> >> 5. ssl is now used from the sfwnv gate (proto area) instead of the installed >> system (build machine). Please see --with-ssl change in Makefile.sfw file. >> >> 6. Added 'env -' for all relevant targets. >> >> 7. MAKE=$(CCSMAKE) removed from all $(CCSMAKE) invocations. The MAKE macro is >> correctly set by /usr/ccs/bin/make, so it is not needed to be set explicitly. >> >> 8. Removed fetchmailconf.1 man page from the post process. Because >> fetchmailconf.1 includes whole fetchmail.1, the Sun specific addition was in >> the fetchmailconf.1 twice (bug). >> >> 9. Removed specific additions to LDFLAGS. None of them are needed. >> >> 10. Removed INSTALL=/usr/bin/ginstall from the install target. The install >> program is already correctly detected by configure. > > #10 now reads: > > 10. install-proto is now used for installation: CONFIGURE_OPTIONS += > INSTALL="$(INSTALL)". This sets correct permissions for executable files (555, > instead of previous 755) and performs post processing, so POST_PROCESS_BIN in > Makefile.sfw is no longer needed. > >> 11. Switched to python2.6. This version of python should be default in >> OpenSolaris since snv_131. >> >> 12. Replaced /usr/bin/fetchmailconf link by real script as intended by >> fetchmail authors. The /usr/bin/fetchmailconf is now correctly generated >> because of correctly forced python version for the ./configure script (see >> PYTHON="$(PYTHONBIN)" and am_cv_python_pythondir="$(PYTHONDIR)" configure >> options). >> >> 13. /usr/lib/python2.6/vendor-packages/fetchmailconf.py is no longer >> executable >> (no longer required because /usr/bin/fetchmailconf is no longer link to >> fetchmailconf.py). >> >> 14. shebang for /usr/lib/python2.6/vendor-packages/fetchmailconf.py is >> modified >> to use explicit version of python (2.6) - please see the PERL line in the >> Makefile.sfw. > > 15. All data files are now installed read only: CONFIGURE_OPTIONS += > INSTALL_DATA='$${INSTALL} -m 444' > > 16. usr/src/tools/sunman.sh is modified to preserve permissions of the > processed > man page. > > 17. Because of #10, #15, and #16 above, all files are now installed read only. > > > Thank you. > -- Paul Cunningham Software Engineer Tel: 01462 685974
