Vladimir Kotal wrote:

<snip>

> ok, I will rewrite the tests in nc test suite to use double brackets.

After reading the shell style document I made the following changes:
   - used double square brackets for if tests
   - converted escape characters to $( )
   - converted function definitions to 'function { }'
   - fixed if/for style
     - then/do on the same line as the check
     - semicolon separated by space from ']]'

new webrev is here:
 
http://cr.opensolaris.org/~vkotal/nc-tet.onnv-stc2-restructured-ksh_style/

Also, I filed the following RFE for kstyle script:

   6725245 need a kstyle script for checking ksh style


v.

Reply via email to