Hi,
On Sat, Jul 12, 2008 at 12:31:59PM +0200, Vladimir Kotal wrote:
> Vladimir Kotal wrote:
>
> <snip>
>
> > ok, I will rewrite the tests in nc test suite to use double brackets.
>
> After reading the shell style document I made the following changes:
> - used double square brackets for if tests
> - converted escape characters to $( )
> - converted function definitions to 'function { }'
> - fixed if/for style
> - then/do on the same line as the check
> - semicolon separated by space from ']]'
Looks good to me.
Nitpicking - is the semicolon separation really necessary? I see
some other cases within your code, where the semicolon hasn't
been separated. Do we have some reason for such separation? It
is not mentioned in the ksh style guidelines; yes, examples use
such separation, but at the same time you can see other
semicolons used throughout the code also separated from the
commads. It is unified unlike in your code.
Team, do we have a chance, off this review discussion, to
discuss and standartize the semicolon usage [1]? Thank you.
>
> new webrev is here:
>
> http://cr.opensolaris.org/~vkotal/nc-tet.onnv-stc2-restructured-ksh_style/
>
> Also, I filed the following RFE for kstyle script:
>
> 6725245 need a kstyle script for checking ksh style
The issue has been little bit discussed in the following thread:
http://www.opensolaris.org/jive/message.jspa?messageID=127197#127197
>
>
> v.
> _______________________________________________
> testing-discuss mailing list
> testing-discuss at opensolaris.org
/j.
[1] http://opensolaris.org/os/project/shell/shellstyle/
