Interesting. We pass -source and -target options of 1.5 to the compiler (see java/gadgets/pom.xml), but apparently the compiler doesn't know how to check which standard library interfaces changed in which JRE release. That shouldn't be surprising, I guess.
On Tue, Mar 18, 2008 at 1:46 PM, Kevin Brown <[EMAIL PROTECTED]> wrote: > I don't think we ever explicitly targeted a specific version of Java to use, > but I do feel that we should probably support Java 5. I'd be happy to add > this to our coding guidelines (which are here, by the way: > http://cwiki.apache.org/confluence/display/SHINDIGxSITE/Java+Style) > > > > On Tue, Mar 18, 2008 at 1:33 PM, Michael Papp <[EMAIL PROTECTED]> wrote: > > > Hi, > > > > Up until the yesterday I could build and run Shindig on Java 5. Some > > recent > > commits have broken Java 5 compatibility. Some background: I have > > started > > work on Shindig as an observer and have/will submit patches to the project > > (at least until you guys get fed up with me). I have worked on a number > > of > > open source projects (Moz and a few of my own) and currently represent > > Piczo > > (www.piczo.com), a social networking company (what else?). We intend to > > use > > Shindig for our OpenSocial implementation and we are close to hosting an > > internal implementation of Shindig for experimental purposes. We are > > currently using Java 5 and have no intention of moving to Java 6 anytime > > soon. If the project's consensus is to base the code on Java 6, I can > > keep > > our in-house version patched for Java 5 compatibility. I am bringing this > > up primarily to ask if this is a conscious decision, or did this just slip > > in unnoticed: > > > > > > The method isEmpty() is undefined for the type String > > java/org/apache/shindig/social GadgetDataServlet.java line 101 > > The method isEmpty() is undefined for the type String > > /java/org/apache/shindig/social/samplecontainer > > XmlStateFileFetcher.java > > > > There are also errors on: > > > > The method appendTo(StringBuffer) of type > > ProxyHandlerTest.SignedFetchArgumentMatcher must override a superclass > > method java/org/apache/shindig/gadgets/http ProxyHandlerTest.java > > line 159 > > > > The method createToken(String) of type new GadgetSigner(){} must override > > a > > superclass method test/java/org/apache/shindig/gadgets > > GadgetTestFixture.java line 59 > > > > The method matches(Object) of type > > ProxyHandlerTest.SignedFetchArgumentMatcher must override a superclass > > method test/java/org/apache/shindig/gadgets/http ProxyHandlerTest.java > > line 166 1205795935335 1730 > > > > which appeared on in the last few days. Again, no (major) complaints > > about > > basing on Java 6, just letting you know that you are doing so (and as a > > rabid Mac user and longtime Apple employee in the past, you are cutting > > off > > development/deployment on the Mac, too). > > > > > > -- > > Michael Papp > > [EMAIL PROTECTED] > > > > > > -- > ~Kevin >
