[
https://issues.apache.org/jira/browse/SHINDIG-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589174#action_12589174
]
vasu nori commented on SHINDIG-199:
-----------------------------------
XmlStateFileFetcher.java could use some refactoring during this patch. It
currently uses ContentFetcher to get at the sample data xml file. That
introduces dependency with code in java/gadgets dir code
(BasicRemoteContentFetcher).
I'd say, there should be NO dependency by java/social/ on code in
java/gadgets/ code.
XmlStateFileFetcher could simply do file I/O to read the XML file, to remove
this particular dependency.
and a nitpick: all POJOs in social/opensocial/model/ extend AbstractGadgetData.
It should be called AbstractModelEntity or something and remove the word
"gadget" from it.
> Move the social java code into the java/social-api component
> ------------------------------------------------------------
>
> Key: SHINDIG-199
> URL: https://issues.apache.org/jira/browse/SHINDIG-199
> Project: Shindig
> Issue Type: Improvement
> Components: RESTful API (Java)
> Reporter: Cassie Doll
> Assignee: Cassie Doll
> Attachments: move_social_code.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
