[ 
https://issues.apache.org/jira/browse/SHINDIG-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589473#action_12589473
 ] 

Cassie Doll commented on SHINDIG-199:
-------------------------------------

I absolutely agree that the dependency is horrible. Unfortunately, simply 
refactoring XmlStateFileFetcher will not remove all of the gadgets 
dependencies. The second step in refactoring all of our code is to make a 
java/common directory with all of the common code (including the content 
fetcher) in it. 

With that in mind, I think trying to refactor all of the common dependencies 
away would make this change huge and unbearable. The next step will be to 
immediately fix that though. 

As for AbstractGadgetData, my hopes were that all of this data fetching stuff 
will become more general and encompass non-social things.. that's why the 
servlet is called GadgetDataServlet. There's been some talk about the restful 
spec allowing non-social data as well (like music and whatnot). You make a good 
point though, we should probably rename it in a later change. 

> Move the social java code into the java/social-api component
> ------------------------------------------------------------
>
>                 Key: SHINDIG-199
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-199
>             Project: Shindig
>          Issue Type: Improvement
>          Components: RESTful API (Java)
>            Reporter: Cassie Doll
>            Assignee: Cassie Doll
>         Attachments: move_social_code.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to