If we're going to be pedantic about these sorts of things we should
enforce them with checkstyle. This way the checkin that activates the
rule can include all the fixes to get the codebase in conformance.
On Mar 10, 2009, at 2:24 AM, Ian Boston wrote:
Here is my logic:
1. Patches should only change the lines that they relate to, if a
patch fixes a bug, thats all it should do.
2. To help achieve 1 we have a style guide, so we should not need to
change lines of code just for formatting or because its not the way
our IDE is configured to do things.
3. The more we deviate from the style guide, the more effort is
going to be required to achieve patches satisfy 1.
4. No code base is perfect, all committers are human and every now
and again we are going to need a style amnesty to get the code base
back to a consistent form, so its probably better to do this in one
commit per module so that its easily identifiable as such.
The deviations from style that exist in shindig may be tolerable,
but judging from the fact that this thread exists, they are not.
There is tension between using IDE automation and keeping to 1.
Ian
On 9 Mar 2009, at 15:12, Adam Winer wrote:
What's your reason for favoring
cleanup?
