Would that be a bit OTT?
It would be very frustrating if the build failed all the time because
of white space mistakes, I am thinking about local development rather
than committed code.
Last time I looked
Social API had 204 style errors, 129 warnings and 1051 infos
Gadgets 595 errors, 351 warnings 2016 infos
Common 383 errors 66 warnings and 752 infos
That information is a bit old but if gives an idea of the distance
between the checkstyle.xml and the code base. (BTW, I dont think that
checkstyle.xml is correct at the moment, but it might be close)
Ian
On 10 Mar 2009, at 17:51, Paul Lindner wrote:
checkstyle runs in the reporting profile, which means that it's not
really enforced. If we run it during the build/test phase then we
can enforce style.
On Mar 10, 2009, at 9:51 AM, Vincent Siveton wrote:
Paul,
2009/3/10 Paul Lindner <[email protected]>:
If we're going to be pedantic about these sorts of things we
should enforce
them with checkstyle. This way the checkin that activates the
rule can
include all the fixes to get the codebase in conformance.
As I already mentioned in this thread, our Checkstyle conf [1]
already
checks for trailing space.
Cheers,
Vincent
[1] http://svn.apache.org/repos/asf/incubator/shindig/trunk/site/checkstyle.xml
