http://codereview.appspot.com/14088/diff/2001/3006 File java/common/src/main/java/org/apache/shindig/protocol/conversion/BeanJsonConverter.java (right):
http://codereview.appspot.com/14088/diff/2001/3006#newcode77 Line 77: // Ensure consistent method ordering by using a linked hash map. comment doesn't match code (didn't before, either) http://codereview.appspot.com/14088/diff/2001/3006#newcode91 Line 91: private static String getPropertyName(Method method) { method -> setter? Clearer that this only works with set() methods. http://codereview.appspot.com/14088/diff/2001/3006#newcode94 Line 94: String name = method.getName(); this includes static methods as well as non-static; and methods with multiple args or no args. Shouldn't it be a bit more restrictive (at least for the no-annotation codepath)? http://codereview.appspot.com/14088/diff/2001/3006#newcode139 Line 139: return value; return Boolean.TRUE.equals(value)? Or "true".equals(String.valueOf(type)); http://codereview.appspot.com/14088/diff/2001/3006#newcode175 Line 175: } else if (Collection.class.isAssignableFrom(clazz)) { List<T> is missing http://codereview.appspot.com/14088/diff/2001/3006#newcode216 Line 216: for (Object o : type.getEnumConstants()) { could be just Enum.valueOf(type, value); http://codereview.appspot.com/14088/diff/2001/3006#newcode240 Line 240: Object out = injector.getInstance(Key.get(type)); injector.getInstance(type); http://codereview.appspot.com/14088
