http://codereview.appspot.com/14088/diff/2001/3006 File java/common/src/main/java/org/apache/shindig/protocol/conversion/BeanJsonConverter.java (right):
http://codereview.appspot.com/14088/diff/2001/3006#newcode175 Line 175: } else if (Collection.class.isAssignableFrom(clazz)) { On 2009/03/17 17:25:54, etnu00 wrote:
On 2009/03/17 15:09:44, awiner wrote: > List<T> is missing
How so? Collection.class.isAssignableFrom should cover any collection
type,
including lists. Set is explicit because it's meaningfully different
when
requested, but if it wasn't requested explicitly, a List is the most
accurate
fall back type.
Good point. http://codereview.appspot.com/14088/diff/2001/3006#newcode240 Line 240: Object out = injector.getInstance(Key.get(type)); On 2009/03/17 17:25:54, etnu00 wrote:
On 2009/03/17 15:09:44, awiner wrote: > injector.getInstance(type);
getInstance doesn't work on Type, it works on Class<?>, or Key. I'd
have to cast
to Class<?>, which would make parameterized type population break.
See line 239: this is a Class<?> here, not a Type. http://codereview.appspot.com/14088
